Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13661] Sema: lift "same-file-only derivative registration" limitation #54287

Closed
dan-zheng opened this issue Nov 29, 2019 · 3 comments
Closed

[SR-13661] Sema: lift "same-file-only derivative registration" limitation #54287

dan-zheng opened this issue Nov 29, 2019 · 3 comments
Assignees
@dan-zheng

Comments

@dan-zheng
Copy link
Collaborator

Previous ID SR-13661
Radar None
Original Reporter @dan-zheng
Type Sub-task
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s
Labels Sub-task
Assignee @dan-zheng
Priority Medium

md5: e13a174a62fdf33f6a15f28521a184d2

Parent-Task:

  • SR-13659 Retroactive derivative registration

is blocked by:

  • SR-13669 Differentiation: revamp transform to directly canonicalize differentiability witnesses

relates to:

  • TF-1042 [AD] RemoveASTContext::{Differentiable,Derivative}Attrs

Issue Description:

After differentiability witnesses are used end-to-end (#28451 it should be possible to remove the "same-file-only derivative registration" limitation for @derivative attribute type-checking.
@dan-zheng
Copy link
Collaborator Author

WIP at https://github.com/dan-zheng/swift/commits/derivative-attr-silgen.
The change is straightforward but is blocked by TF-1024: changing the differentiation transform to directly canonicalize differentiability witnesses instead of SIL [differentiable] attributes.

@marcrasi
Copy link
Mannequin

marcrasi mannequin commented Jan 8, 2020

Restriction is currently lifted for the stdlib, using the `-Xllvm -enable-experimental-cross-file-derivative-registration` flag. This is good enough for TF-959. I'll leave this ticket open to track making cross-file derivatives fully robust and ready to turn on by default.

@dan-zheng
Copy link
Collaborator Author

Done in #31249

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-zheng dan-zheng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dan-zheng