Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13668] SILOptimizer: devirtualize differentiability_witness_function instructions #54252

Closed
dan-zheng opened this issue Nov 24, 2019 · 1 comment
Closed

[SR-13668] SILOptimizer: devirtualize differentiability_witness_function instructions #54252

dan-zheng opened this issue Nov 24, 2019 · 1 comment
Assignees
@marcrasi

Comments

@dan-zheng
Copy link
Collaborator

Previous ID SR-13668
Radar None
Original Reporter @dan-zheng
Type Sub-task
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s
Labels Sub-task
Assignee @marcrasi
Priority Medium

md5: 5f602f3bd32262763c28fdde561d04a4

Parent-Task:

  • SR-13659 Retroactive derivative registration

Issue Description:

Devirtualizing differentiability_witness_function instructions to function_ref should positively impact performance.

Reference: lib/SILOptimizer/Utils/Devirtualize.cpp handles class_method and witness_method instructions.
@dan-zheng
Copy link
Collaborator Author

Done in #28480

A new "DifferentiabilityWitnessDevirtualizer" function transform was created. This was simpler than hooking into swift::tryDevirtualizeApply: #28480 (comment)

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcrasi marcrasi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dan-zheng