Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13680] figure out correct linkage for all ad symbols #54307

Closed
marcrasi mannequin opened this issue Dec 3, 2019 · 0 comments
Closed

[SR-13680] figure out correct linkage for all ad symbols #54307

marcrasi mannequin opened this issue Dec 3, 2019 · 0 comments
Assignees

Comments

@marcrasi
Copy link
Mannequin

marcrasi mannequin commented Dec 3, 2019

Previous ID SR-13680
Radar None
Original Reporter @marcrasi
Type Sub-task
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s
Labels Sub-task
Assignee @marcrasi
Priority Medium

md5: e6812d0f10ce90901828db6ef6e69971

Parent-Task:

  • SR-13659 Retroactive derivative registration

relates to:

  • TF-1025 using default @differentiable function arguments from multiple files causes duplicate definition of diff witness
  • TF-690 [AD] Linker error regarding AD associated functions of default argument closures

Issue Description:

Some bugs are probably caused by incorrect linkage, or bad interactions between serialization and linkage (TF-1025, TF-690).

The error mentioned here #28532 (comment) is probably also caused by this.

We should carefully think through linkage and serialization for ad symbols and come up with a simple, robust solution.

Note: Check if there is existing SIL infra for determining linkage of generated things.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants