Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13763] SourceKit-LSP should provide a better error when a "notification" is sent as a "request" #528

Closed
benlangmuir opened this issue Oct 21, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@benlangmuir
Copy link
Member

Previous ID SR-13763
Radar rdar://problem/70546466
Original Reporter @benlangmuir
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s SourceKit-LSP
Labels Improvement
Assignee None
Priority Medium

md5: eeb6e0002ae127c14c5a2f79b3cf1187

Issue Description:

If a client incorrectly sends a notification message with a request id, we currently send the response "method not found: <method name>".

We should improve this error by checking if the method is a known notification so that it is clear what the issue is. E.g.

"<method name> is a notification message, but received as a request"

@typesanitizer
Copy link

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
@ahoppen ahoppen added enhancement New feature or request good first issue Good for newcomers and removed Improvement labels Aug 22, 2022
@ahoppen
Copy link
Collaborator

ahoppen commented Mar 22, 2024

Having worked on sourcekit-lsp for a year now, this never turned out to be an issue. Let’s close it.

@ahoppen ahoppen closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants