Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13840] Xcode produces an invalid application package when adding a Swift Binary Targets #4474

Open
swift-ci opened this issue Nov 10, 2020 · 8 comments
Labels

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-13840
Radar rdar://problem/71330223
Original Reporter karhm (JIRA User)
Type Bug

Attachment: Download

Environment

Xcode 12.1 (12A7403)

macOS 10.15.7 (19H2)

Swift 5.3

Additional Detail from JIRA
Votes 11
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 0c771536479cc1f71eafb8ded2cffc6f

Issue Description:

When adding a Swift Binary Package to an Xcode project that also have an extension the binary package will be copied both to the Plugins folder and the Frameworks folder.

This happen on Xcode 12.1 and earlier.

A sample project to reproduce this bug can be found here:
https://github.com/karimhm/Apple-Radars/tree/main/SwiftBinaryPackageBugSample

To reproduce the bug:

  • Open SwiftBinaryPackageBugSample.xcodeproj Xcode project.

  • Wait for all the packages to resolve.

  • Build or archive the application and examine its structure.

The application bundle look as follow:

@typesanitizer
Copy link

@swift-ci create

@WowbaggersLiquidLunch
Copy link
Collaborator

Here is a workaround provided by Kevin Bui on the Swift Forums: https://forums.swift.org/t/swift-package-binary-framework-issue/41922/3

@haikusw
Copy link

haikusw commented Dec 21, 2020

Reproduced with sample project in Xcode 12.2 (12B45b), Swift 5.3.1, running under macOS v10.15.7

@swift-ci
Copy link
Contributor Author

Comment by Stuart Breckenridge (JIRA)

Reproduced on Xcode 12.3 (12C33), Swift 5.3.1, macOS 11.1.

Given that this behaviour produces a submission-breaking outcome, it should probably be rated higher than Medium.

@swift-ci
Copy link
Contributor Author

Comment by Christopher Prince (JIRA)

Still happening for my app with Xcode 12.4.

@swift-ci
Copy link
Contributor Author

Comment by Stuart Breckenridge (JIRA)

It’s a documented issue in the Xcode 12.4 release notes. Hopefully, it’ll get fixed next release.

@swift-ci
Copy link
Contributor Author

swift-ci commented Mar 1, 2021

Comment by Héctor García Peña (JIRA)

I want to add the Framework files are also added to the following folders (in case the app support such features):

  • Watch

  • AppClips

We had the following errors:

ERROR ITMS-90680: "Invalid directory. The bundle Payload/<undisclosed>/AppClips/<undisclosed>.framework is not contained in a correctly named directory. It should be under "Frameworks"."

...

ERROR ITMS-90680: "Invalid directory. The bundle Payload/<undisclosed>/Watch/<undisclosed>.framework is not contained in a correctly named directory. It should be under "Frameworks"."

@swift-ci
Copy link
Contributor Author

Comment by César Pinto Castillo (JIRA)

I can confirm that this bug no longer happens for me on Xcode v12.5(12E262) RC

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants