Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13889] Remove SILAutoDiffIndices and use AutoDiffConfig instead #54027

Closed
dan-zheng opened this issue Oct 15, 2019 · 2 comments
Closed

[SR-13889] Remove SILAutoDiffIndices and use AutoDiffConfig instead #54027

dan-zheng opened this issue Oct 15, 2019 · 2 comments
Assignees
Labels
compiler The Swift compiler in itself improvement

Comments

@dan-zheng
Copy link
Collaborator

Previous ID SR-13889
Radar rdar://problem/71678394
Original Reporter @dan-zheng
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement
Assignee @rxwei
Priority Medium

md5: 71829f2db7067085fcf17646cb72117b

relates to:

  • TF-1256 SIL: change "source" result index to result indices

Issue Description:

SILAutoDiffIndices is the data structure stored in SILDifferentiableAttr representing a "differentiable SIL function configuration": parameter indices and result index.

AutoDiffConfig is a new data structure used in SILDifferentiabilityWitness that stores parameter indices, result indices, and derivative generic signature.
AutoDiffConfig should replace all uses of SILAutoDiffIndices, e.g. in helper functions like SILFunctionType::getAutoDiffDerivativeFunctionType.

@rxwei
Copy link
Member

rxwei commented Nov 23, 2020

@swift-ci create

@rxwei
Copy link
Member

rxwei commented Dec 14, 2020

#35079

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself improvement
Projects
None yet
Development

No branches or pull requests

2 participants