Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13916] Add XCTIssue and record(_:) #348

Open
dabrahams opened this issue Nov 28, 2020 · 4 comments · May be fixed by #466
Open

[SR-13916] Add XCTIssue and record(_:) #348

dabrahams opened this issue Nov 28, 2020 · 4 comments · May be fixed by #466
Labels
bug XCTest

Comments

@dabrahams
Copy link

Previous ID SR-13916
Radar rdar://problem/71912814
Original Reporter @dabrahams
Type Bug
Additional Detail from JIRA
Votes 0
Component/s XCTest
Labels Bug
Assignee None
Priority Medium

md5: 38ef84ef694bb74c05c6a9d84522bbe4

Issue Description:

https://developer.apple.com/documentation/xctest/xctestrun/1449632-recordfailure is supposedly deprecated in favor of record(_:XCTIssue), since like, forever, but XCTIssue doesn't even exist in https://github.com/apple/swift-corelibs-xctest
@typesanitizer
Copy link

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
@grynspan
Copy link
Contributor

Sorry for the late reply.

The XCTest documentation at developer.apple.com tracks the XCTest framework that ships as part of Xcode. Retitling this issue to track adding XCTIssue.

@grynspan grynspan changed the title [SR-13916] Documentation out-of-sync with OSS codebase [SR-13916] Add XCTIssue and record(_:) Aug 16, 2023
@dabrahams
Copy link
Author

In that case, here are two new issues for you, which better reflect my orginal intent in filing this one: #461, #462

@grynspan
Copy link
Contributor

Thanks for filing those issues. I agree corelibs-xctest's documentation story can be improved.

@grynspan grynspan mentioned this issue Sep 12, 2023
Open
grynspan added a commit that referenced this issue Oct 6, 2023
@grynspan
Add a basic implementation of XCTIssue.
82d6aa2 
This PR adds a basic implementation of `XCTIssue` and `record(_:)`. The implementation is not as complex as the one in the XCTest framework that ships in Xcode. The interface is equivalent.

Resolves #348.
@grynspan grynspan linked a pull request Oct 6, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug XCTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a basic implementation of XCTIssue. apple/swift-corelibs-xctest
3 participants
@dabrahams @grynspan @typesanitizer