We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
md5: e134a3763af24d57d0b69909f6a1e63d
Issue Description:
I tried 3 builds, and for each build, I checked the compilation command for SILVerifier.cpp in compile_commands.json.
SILVerifier.cpp
compile_commands.json
1. build-script --release --no-assertions <other flags>: preprocessor flags -DGTEST_HAS_RTTI=0 -DNDEBUG -D__STDC_CONSTANT_MACROS. 2. build-script --release --no-llvm-assertions <other flags>: preprocessor flags -DGTEST_HAS_RTTI=0 -DNDEBUG -D__STDC_CONSTANT_MACROS. 3. build-script --release <other flags>: preprocessor flags -DGTEST_HAS_RTTI=0 -DSWIFT_ENABLE_RUNTIME_FUNCTION_COUNTERS -D_DEBUG -D__STDC_CONSTANT_MACROS.
build-script --release --no-assertions <other flags>
-DGTEST_HAS_RTTI=0 -DNDEBUG -D__STDC_CONSTANT_MACROS
build-script --release --no-llvm-assertions <other flags>
build-script --release <other flags>
-DGTEST_HAS_RTTI=0 -DSWIFT_ENABLE_RUNTIME_FUNCTION_COUNTERS -D_DEBUG -D__STDC_CONSTANT_MACROS
I think the second one is incorrect; like the third case, it should not be passing -DNDEBUG when building the Swift compiler.
-DNDEBUG
The text was updated successfully, but these errors were encountered:
@swift-ci create
Sorry, something went wrong.
PR: #35115
typesanitizer
No branches or pull requests
Additional Detail from JIRA
md5: e134a3763af24d57d0b69909f6a1e63d
Issue Description:
I tried 3 builds, and for each build, I checked the compilation command for
SILVerifier.cpp
incompile_commands.json
.1.
build-script --release --no-assertions <other flags>
: preprocessor flags-DGTEST_HAS_RTTI=0 -DNDEBUG -D__STDC_CONSTANT_MACROS
.2.
build-script --release --no-llvm-assertions <other flags>
: preprocessor flags-DGTEST_HAS_RTTI=0 -DNDEBUG -D__STDC_CONSTANT_MACROS
.3.
build-script --release <other flags>
: preprocessor flags-DGTEST_HAS_RTTI=0 -DSWIFT_ENABLE_RUNTIME_FUNCTION_COUNTERS -D_DEBUG -D__STDC_CONSTANT_MACROS
.I think the second one is incorrect; like the third case, it should not be passing
-DNDEBUG
when building the Swift compiler.The text was updated successfully, but these errors were encountered: