Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13934] build-script's --no-llvm-assertions also disables assertions for Swiftc #56331

Open
typesanitizer opened this issue Dec 4, 2020 · 2 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@typesanitizer
Copy link

Previous ID SR-13934
Radar rdar://problem/71983181
Original Reporter @typesanitizer
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug
Assignee @typesanitizer
Priority Medium

md5: e134a3763af24d57d0b69909f6a1e63d

Issue Description:

I tried 3 builds, and for each build, I checked the compilation command for SILVerifier.cpp in compile_commands.json.

1. build-script --release --no-assertions <other flags>: preprocessor flags -DGTEST_HAS_RTTI=0 -DNDEBUG -D__STDC_CONSTANT_MACROS.
2. build-script --release --no-llvm-assertions <other flags>: preprocessor flags -DGTEST_HAS_RTTI=0 -DNDEBUG -D__STDC_CONSTANT_MACROS.
3. build-script --release <other flags>: preprocessor flags -DGTEST_HAS_RTTI=0 -DSWIFT_ENABLE_RUNTIME_FUNCTION_COUNTERS -D_DEBUG -D__STDC_CONSTANT_MACROS.

I think the second one is incorrect; like the third case, it should not be passing -DNDEBUG when building the Swift compiler.

@typesanitizer
Copy link
Author

@swift-ci create

@typesanitizer
Copy link
Author

PR: #35115

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Development

No branches or pull requests

1 participant