Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14105] [rebranch] C++ interop test failures on iOS simulator #56491

Closed
xymus opened this issue Jan 25, 2021 · 5 comments
Closed

[SR-14105] [rebranch] C++ interop test failures on iOS simulator #56491

xymus opened this issue Jan 25, 2021 · 5 comments
Assignees
@aschwaighofer
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@xymus
Copy link
Contributor

xymus commented Jan 25, 2021

Previous ID SR-14105
Radar rdar://problem/73591415
Original Reporter @xymus
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee @aschwaighofer
Priority Medium

md5: 6a072f0b498e3a68ce06a073abe19c94

relates to:

  • SR-14107 [rebranch] IRGet test failures on iphonesimulator-i386

Issue Description:

Two C++ interop tests are failing on the iOS simulator with rebranch.

https://ci.swift.org/view/Swift%20rebranch/job/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/2/console

22:17:47   Swift(iphonesimulator-i386) :: Interop/Cxx/operators/member-inline-irgen.swift
22:17:47   Swift(iphonesimulator-i386) :: Interop/Cxx/operators/member-out-of-line-irgen.swift

FAIL: Swift(iphonesimulator-i386) :: Interop/Cxx/operators/member-inline-irgen.swift (8740 of 14079)
******************** TEST 'Swift(iphonesimulator-i386) :: Interop/Cxx/operators/member-inline-irgen.swift' FAILED ********************
Script:
--
: 'RUN: at line 1';   /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/swift-macosx-x86_64/bin/swift-frontend -target i386-apple-ios7.0-simulator  -module-cache-path /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/swift-macosx-x86_64/swift-test-results/i386-apple-ios7.0-simulator/clang-module-cache -sdk '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.3.sdk'  -swift-version 4  -ignore-module-source-info -typo-correction-limit 10  -emit-ir -verify-syntax-tree /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-inline-irgen.swift -I /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/Inputs -enable-cxx-interop | /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/utils/PathSanitizingFileCheck --sanitize BUILD_DIR=/Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/swift-macosx-x86_64 --sanitize SOURCE_DIR=/Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift --use-filecheck /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/llvm-macosx-x86_64/bin/FileCheck  /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-inline-irgen.swift
--
Exit Code: 1

Command Output (stderr):
--
/Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-inline-irgen.swift:10:11: error: CHECK: expected string not found in input
// CHECK: call [[RES:i32|i64]] [[NAME:@(_ZN18LoadableIntWrappermiES_|"\?\?GLoadableIntWrapper@@QEAA\?AU0@U0@@Z")]](%struct.LoadableIntWrapper* {{%[0-9]+}}, {{i32|\[1 x i32\]|i64|%struct.LoadableIntWrapper\* byval align 4}} {{%[0-9]+}})
          ^
<stdin>:1:1: note: scanning from here
; ModuleID = '<swift-imported-modules>'
^

Input file: <stdin>
Check file: /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-inline-irgen.swift

-dump-input=help explains the following input dump.

Input was:
<<<<<<
          1: ; ModuleID = '<swift-imported-modules>'
check:10     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
          2: source_filename = "<swift-imported-modules>"
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          3: target datalayout = "e-m:o-p:32:32-p270:32:32-p271:32:32-p272:64:64-f64:32:64-f80:128-n8:16:32-S128"
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          4: target triple = "i386-apple-ios7.0.0-simulator"
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          5: 
check:10     ~
          6: %TSo18LoadableIntWrapperV = type <{ %Ts5Int32V }>
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          .
          .
          .
>>>>>>

--

********************
...
FAIL: Swift(iphonesimulator-i386) :: Interop/Cxx/operators/member-out-of-line-irgen.swift (8742 of 14079)
******************** TEST 'Swift(iphonesimulator-i386) :: Interop/Cxx/operators/member-out-of-line-irgen.swift' FAILED ********************
Script:
--
: 'RUN: at line 1';   /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/swift-macosx-x86_64/bin/swift-frontend -target i386-apple-ios7.0-simulator  -module-cache-path /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/swift-macosx-x86_64/swift-test-results/i386-apple-ios7.0-simulator/clang-module-cache -sdk '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.3.sdk'  -swift-version 4  -ignore-module-source-info -typo-correction-limit 10  -emit-ir -verify-syntax-tree /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-out-of-line-irgen.swift -I /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/Inputs -enable-cxx-interop | /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/utils/PathSanitizingFileCheck --sanitize BUILD_DIR=/Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/swift-macosx-x86_64 --sanitize SOURCE_DIR=/Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift --use-filecheck /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/Ninja-ReleaseAssert/llvm-macosx-x86_64/bin/FileCheck  /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-out-of-line-irgen.swift
--
Exit Code: 1

Command Output (stderr):
--
/Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-out-of-line-irgen.swift:10:11: error: CHECK: expected string not found in input
// CHECK: call {{i32|i64}} [[NAME:@_ZNK6IntBoxplES_]](%struct.IntBox* %{{[0-9]+}}, {{i32|\[1 x i32\]|i64|%struct.IntBox\* byval align 4}} %{{[0-9]+}})
          ^
<stdin>:1:1: note: scanning from here
; ModuleID = '<swift-imported-modules>'
^

Input file: <stdin>
Check file: /Volumes/swift-ci/jenkins/workspace/oss-swift-rebranch_tools-RA_stdlib-RDA_test-simulator/swift/test/Interop/Cxx/operators/member-out-of-line-irgen.swift

-dump-input=help explains the following input dump.

Input was:
<<<<<<
          1: ; ModuleID = '<swift-imported-modules>'
check:10     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
          2: source_filename = "<swift-imported-modules>"
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          3: target datalayout = "e-m:o-p:32:32-p270:32:32-p271:32:32-p272:64:64-f64:32:64-f80:128-n8:16:32-S128"
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          4: target triple = "i386-apple-ios7.0.0-simulator"
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          5: 
check:10     ~
          6: %TSo6IntBoxV = type <{ %Ts5Int32V }>
check:10     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          .
          .
          .
>>>>>>

--

********************
@xymus
Copy link
Contributor Author

xymus commented Jan 25, 2021

@zoecarver or @compnerd can you take a look at these? It's probably not a new failure as we only recently have been getting far away in CI testing of rebranch to run the full test suite on the iOS simulator.

@xymus
Copy link
Contributor Author

xymus commented Jan 25, 2021

@swift-ci create

@xymus
Copy link
Contributor Author

xymus commented Jan 25, 2021

This may be a more general IRGen issue. The other failures are:

22:17:47   Swift(iphonesimulator-i386) :: IRGen/objc_simd.sil
22:17:47   Swift(iphonesimulator-i386) :: IRGen/pic.swift

@zoecarver
Copy link
Collaborator

I'd be willing to bet this is just a regex comment that needs to be updated for 32-bit targets. I can investigate in the next day or two when I have a bit of free time.

@aschwaighofer
Copy link
Member

Recent llvm requires byVal (and structRet) attributes to be annotated with the type e.g. byVal(%myType).

Fixed in 8242ae7

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aschwaighofer aschwaighofer

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xymus @zoecarver @aschwaighofer