Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-14130] [Property Wrappers] Improve composed wrapped value mismatch error message #56511

Open
hborla opened this issue Jan 29, 2021 · 0 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation property wrappers Feature: property wrappers

Comments

@hborla
Copy link
Member

hborla commented Jan 29, 2021

Previous ID SR-14130
Radar rdar://65284161
Original Reporter @hborla
Type Bug
Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Bug, DiagnosticsQoI, PropertyWrappers
Assignee sages (JIRA)
Priority Medium

md5: fe0df8d59c484bd133a0dd9ca34ddc12

Issue Description:

A refactoring of property wrapper constraint generation introduced the following error messages:

property type ‘X’ does not match ‘wrappedValue’ type ‘Y’
composed wrapper type ‘X’ does not match former ‘wrappedValue’ type ‘Y’

There isn't a lot of context for the wrappedValue type in these error messages. We can enhance these error messages by including the property wrapper type, such as:

composed wrapper type ‘X’ does not match the type of ‘Wrapper.wrappedValue' which is ‘Y’

We could also add a note that points to the wrappedValue declaration.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation property wrappers Feature: property wrappers
Projects
None yet
Development

No branches or pull requests

1 participant