[SR-14138] Replace uses of std::transform with llvm::transform where applicable #56518
Comments
|
Feel free to tag me for review on GitHub (@ varungandhi-apple), or ask any questions you might have here. This change should be hopefully simple to implement, the main task in some sense that you can build the compiler properly by following the instructions in the Readme and the Getting Started guide. Feel free to ask build-related questions as well, if you're facing issues with it. @swift-ci create |
|
Comment by Shreya Sharma (JIRA) Hello, I'll be working on this issue. |
|
Sounds good. |
|
Comment by Shreya Sharma (JIRA) I've made a PR for the changes https://github.com/apple/swift/pull/35757. The tests are still pending, but they passed locally. I'm new to swift forum, is there somewhere I can introduce myself? |
|
We have the Development Category on the forums in case you have questions. I'm not sure if we've had people introduce themselves before in an explicit thread there, but if you're interested in contributing and would like to start a conversation and get to know people, I think that creating a thread in that category should be okay. There is also the Women in Swift group. https://forums.swift.org/g/Women-in-Swift If you'd like to be added to it, you can message @hborla or one of the other group owners. They do have explicit introduction threads and I'm told they are "extremely wholesome". 🙂 |
|
Comment by Shreya Sharma (JIRA) Thank you 🙂 |
Additional Detail from JIRA
md5: 800dc234b780460d301595d210ec43f7
Issue Description:
In many places, the code is using
std::transform(x.begin(), x.end() ...). This can be replaced withllvm::transform(x, ...)to simplify the code a little bit. [Note that this won't be a valid replacement if the iteration isn't happening from the beginning to the end.]You may need to add a
#include "llvm/ADT/STLExtras.h"for certain files for this to work, since that's wherellvm::transformis defined.Since this is a pure refactoring, no new test cases are needed.
The text was updated successfully, but these errors were encountered: