Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-14199] [docs] Add some short documentation on dynamic subclassing + KVO #56577

Closed
typesanitizer opened this issue Feb 12, 2021 · 3 comments
Closed
Labels
compiler The Swift compiler in itself documentation task

Comments

@typesanitizer
Copy link

Previous ID SR-14199
Radar rdar://problem/74277185
Original Reporter @typesanitizer
Type Task
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task, Documentation
Assignee mininny (JIRA)
Priority Medium

md5: 82d1521b2da3993352ff9cb1c2ea377e

Issue Description:

Mike has written a nice article on how the ObjC runtime implements KVO using dynamic subclassing. https://www.mikeash.com/pyblog/friday-qa-2009-01-23.html

We should probably create a named note in one place which summarizes the description in the article, and mention that note from places in the runtime where it applies. For example, there are at least a couple of places: TargetClassMetadata::isArtificialSubclass and swift_objc_classCopyFixupHandler.

For examples of existing notes and how we refer to them, search for "[NOTE: " in the compiler's source code. One such note is [NOTE: ModuleInterfaceLoader-defer-to-ImplicitSerializedModuleLoader].

@typesanitizer
Copy link
Author

@swift-ci create

@typesanitizer
Copy link
Author

I think this might be a bit too complicated for being a StarterDocs bug, but in case you'd like to have a go at it, that's okay as well. 👍

@swift-ci
Copy link
Collaborator

Comment by Minhyuk Kim (JIRA)

theindigamer (JIRA User) I attempted to write a draft here: #36955 I'm not sure if this is what you described, and I'd appreciate it if you take a look at it 🙂

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself documentation task
Projects
None yet
Development

No branches or pull requests

2 participants