Feel free to ping me on GitHub for review (@ varungandhi-apple), or ask questions here.

@swift-ci create

Comment by Hongjing Chen (JIRA)

Hello, can I try to work on this as my first contribution? theindigamer (JIRA User)

Hope I don't misunderstand what you mean. I have some quetions. The correct thing is that the code should be regareded as a trailing closure, right? Do we expect an error to occur when testing?

The correct thing is that the code should be regareded as a trailing closure, right?

Yes, that's correct.

Do we expect an error to occur when testing?

We don't expect any error to happen during testing, but the reason to add the test case (in case it doesn't exist already) is to avoid regressing this edge case when changing the parser. Sometimes one might forget to realize all the edge cases that one needs to consider, and make some change assuming that it won't break anything, but in reality there is some edge case which does break. So it's helpful to have tests for edge cases even if the code is working alright.

Comment by Hongjing Chen (JIRA)

Thanks. I’ll check if it needs to be added.

PR opened by Hongjing: #36202

theindigamer (JIRA User), can this be closed now since the PR has been merged?

Thanks Stefano, yeah, we can close this.