Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14328] Semantic Refactoring: Convert Call to Async Alternative issues #56687

Closed
nathawes opened this issue Mar 11, 2021 · 2 comments
Closed

[SR-14328] Semantic Refactoring: Convert Call to Async Alternative issues #56687

nathawes opened this issue Mar 11, 2021 · 2 comments
Assignees
@ahoppen
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. found by stress tester Flag: An issue found by the SourceKit stress tester

Comments

@nathawes
Copy link
Collaborator

Previous ID SR-14328
Radar rdar://problem/75301524
Original Reporter @nathawes
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels Bug, FoundByStressTester
Assignee @ahoppen
Priority Medium

md5: fb707bc1bb7a2159272853878861b9b0

Issue Description:

From projects in the source compatibility suite the stress tester runs on, all the below cases say the refactoring is applicable but hit the errors shown:

response: error response (Request Failed): .../swift-source-compat-suite/project_cache/ACHNBrowserUI/ACHNBrowserUI/ACHNBrowserUI/packages/Backend/Sources/Backend/environments/Items.swift:133:9: error: cannot refactor as callback closure argument missing
        self.spotlightQueue.async {
        ^
response: error response (Request Failed): /Users/nhawes/github/swift-source-compat-suite/project_cache/ACHNBrowserUI/ACHNBrowserUI/ACHNBrowserUI/SceneDelegate.swift:65:13: error: cannot refactor as callback closure argument missing
            DispatchQueue.main.asyncAfter(deadline: .now() + 0.4) {
            ^ 
  response: error response (Request Failed): /Users/nhawes/github/swift-source-compat-suite/project_cache/Dollar/Sources/Dollar.swift:219:9: error: cannot refactor as callback closure argument missing
        queue.asyncAfter(deadline: .now() + interval, execute: function)
        ^

The first two seem like they could work, the last seems like it shouldn't be applicable.
@nathawes
Copy link
Collaborator Author

@swift-ci create

@ahoppen
Copy link
Contributor

ahoppen commented Apr 28, 2021

Fixed in #37071.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahoppen ahoppen

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. found by stress tester Flag: An issue found by the SourceKit stress tester
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahoppen @nathawes