Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14333] 3 Concurrency tests failing on windows #56692

Closed
aschwaighofer opened this issue Mar 11, 2021 · 5 comments
Closed

[SR-14333] 3 Concurrency tests failing on windows #56692

aschwaighofer opened this issue Mar 11, 2021 · 5 comments
Assignees
@compnerd
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself concurrency Feature: umbrella label for concurrency language features

Comments

@aschwaighofer
Copy link
Member

Previous ID SR-14333
Radar rdar://problem/75326006
Original Reporter @aschwaighofer
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, Concurrency
Assignee @compnerd
Priority Medium

md5: 2f3421f0c0573536a7403b4ca85c6f01

Issue Description:

https://ci-external.swift.org/job/swift-PR-windows/11731/consoleText

Failed Tests (3):
Swift(windows-x86_64) :: IRGen/async/throwing.swift
Swift(windows-x86_64) :: Concurrency/Runtime/async_taskgroup_throw_rethrow.swift
Swift(windows-x86_64) :: Concurrency/Runtime/async_task_handle_cancellation.swift
@typesanitizer
Copy link

@swift-ci create

@drodriguez
Copy link
Collaborator

Just a note: I am thinking in disabling `async_task_handle_cancellation.swift` for VS2017 builder in #36530

However, the last two runs for VS2019 has also been failing https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/4750/ and https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/4749/ (it was very sporadic for VS2019 before that).

@drodriguez
Copy link
Collaborator

In #36637 I disable further tests.

  • IRGen/async/throwing.swift started passing in VS2017, but seems to still fail in VS2019. Disabled to avoid breaking the VS2017 build.

  • async_task_detached.swift started failing with an ACCESS_VIOLATION exit code in VS2017, but still seems to pass in VS2019. Also disabled.

Is there a better thing to do that disabling tests one by one until the concurrency support is finished for Windows?

@drodriguez
Copy link
Collaborator

In #36825 I disabled more tests:

  • test/Concurrency/Runtime/yielding_continuation.swift crashing in both VS2017 and VS2019 CI machines. Marked as unsupported, not xfail, to avoid having to change it later.

@drodriguez
Copy link
Collaborator

And another one #36900 test/Concurrency/Runtime/async_task_yield.swift.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drodriguez @typesanitizer @aschwaighofer