Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14416] Remove unused DeclContext parameter from canDecompose #56772

Closed
typesanitizer opened this issue Mar 29, 2021 · 2 comments
Closed

[SR-14416] Remove unused DeclContext parameter from canDecompose #56772

typesanitizer opened this issue Mar 29, 2021 · 2 comments
Labels
compiler The Swift compiler in itself good first issue Good for newcomers task

Comments

@typesanitizer
Copy link

Previous ID SR-14416
Radar None
Original Reporter @typesanitizer
Type Task
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task, StarterBug
Assignee uuttff8 (JIRA)
Priority Medium

md5: ff5fd346394a23ccdbe1f645c1c6ca7d

Issue Description:

The body of the function doesn't utilize the parameter, so there's no point in passing it in, that makes it seem like the context is needed to determine whether the type can be decomposed or not.
@typesanitizer
Copy link
Author

The task itself shouldn't be too challenging, but this is a good opportunity to try building the compiler locally and read some of the pattern engine's code and get familiarized with it.

If you have any questions, be it build issues or anything else, feel free to ask here or on the Swift forums. You can tag me for review on GitHub (@varungandhi-apple).

@swift-ci

@swift-ci
Copy link
Collaborator

Comment by Anton Kuzmin (JIRA)

my PR: #36679

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler The Swift compiler in itself good first issue Good for newcomers task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@typesanitizer @swift-ci