You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SE-0211 proposed (among many other additions) a property called "isDefined". The SE was accepted, and today has "Status: Implemented (Swift 5)".
It looks like changeset 3a2ad05 added the isDefined property, and then d0e93ac removed it. The final merged changeset (for PR#20520, in Nov 2018) doesn't include it or make any mention of it.
In the review thread, there's an exchange:
"If the proposed isDefined property is equivalent to generalCategory != .unassigned, then I’m not sure that it’s worth adding. Or it could be called isAssigned instead."
"Good point; the ICU documentation appears to indicate that this is the case, but I’ll run some tests to see if they differ at any code points just to be sure. The difference may only be in the surrogate code points, which can’t be created as a Unicode.Scalar anyway; if that’s the case, I’ll drop it."
I propose that SE-0211 should be updated with the removal of Unicode.Scalar.Properties.isDefined. (It'd be great if it also mentioned what to use instead.) I think that all other SE proposals I've read were eventually updated with the actual interface that shipped.
The text was updated successfully, but these errors were encountered:
Additional Detail from JIRA
md5: faddd3ac292ad1192f04d3a3ec682b3b
Issue Description:
SE-0211 proposed (among many other additions) a property called "isDefined". The SE was accepted, and today has "Status: Implemented (Swift 5)".
It looks like changeset 3a2ad05 added the isDefined property, and then d0e93ac removed it. The final merged changeset (for PR#20520, in Nov 2018) doesn't include it or make any mention of it.
In the review thread, there's an exchange:
"If the proposed isDefined property is equivalent to generalCategory != .unassigned, then I’m not sure that it’s worth adding. Or it could be called isAssigned instead."
"Good point; the ICU documentation appears to indicate that this is the case, but I’ll run some tests to see if they differ at any code points just to be sure. The difference may only be in the surrogate code points, which can’t be created as a Unicode.Scalar anyway; if that’s the case, I’ll drop it."
https://forums.swift.org/t/se-0211-add-unicode-properties-to-unicode-scalar/12121/23
The review summary doesn't mention this change, however:
https://forums.swift.org/t/accepted-se-0211-add-unicode-properties-to-unicode-scalar/13857
I propose that SE-0211 should be updated with the removal of Unicode.Scalar.Properties.isDefined. (It'd be great if it also mentioned what to use instead.) I think that all other SE proposals I've read were eventually updated with the actual interface that shipped.
The text was updated successfully, but these errors were encountered: