New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-14453] Remove UseSwiftCall/enable_swiftcall frontend option #56809
Comments
@swift-ci create |
As a bonus, if you're interested in deleting code, you can try to see if there are other options which aren't being used anywhere. |
theindigamer (JIRA User) is this jirid@c03c40f what you're looking for? I did not find the option in FrontendOptions.h, I did find it in IRGenOptions.h and removing it did not break the build for me. |
I went through `FrontendOptions.h` and `IRGenOptions.h` and found 2 options that might be removable. FrontendOptions.h: IRGenOptions.h: I prepared 2 independent branches with the changes. The default test suite passes after the removal. theindigamer (JIRA User) please let me know whether you consider these removals valid and would like me to open pull requests. |
Hmm, that's weird. I think for the first one at least, I thought compiler engineers used it for debugging. Maybe there's a bug somewhere and that variable should actually be used. For the second one, Clang does support that as an option. So it seems like a bug that it's not being used anywhere. I'll get back to you on Monday/Tuesday on whether these two should be removed or not. |
@jirid, the DisableLLVMSLPVectorizer flag can be removed. The two flags |
Additional Detail from JIRA
md5: 9b96fff3e1854e58c4eae34c5381cf53
Issue Description:
From what I can tell, it isn't being used anywhere; we've been using the swiftcall convention for several years now.
Remove enable_swiftcall from FrontendOptions.td
Remove UseSwiftCall from FrontendOptions.h and other places it is mentioned.
This shouldn't require any new test cases.
The text was updated successfully, but these errors were encountered: