[SR-14587] refactor-check-compiles should generate both -dump-text and dump-rewritten from a single swift-refactor invocation
#56939
Labels
bug
A deviation from expected or documented behavior. Also: expected but undesirable behavior.
good first issue
Good for newcomers
Comments
|
@swift-ci create |
|
Comment by jiaren wang (JIRA) @ahoppen Like This? def main():
(args, unknown_args) = parse_args()
temp_file_name = os.path.split(args.source_filename)[-1] + '.' + \
args.pos.replace(':', '.')
temp_file_path = os.path.join(args.temp_dir, temp_file_name)
dump_rewritten_output = run_cmd([
args.swift_refactor,
'-dump-rewritten',
'-source-filename', args.source_filename,
'rewritten-output-file', temp_file_path,
'-pos', args.pos
] + unknown_args, desc='producing rewritten file')
run_cmd([
args.swift_frontend,
'-typecheck',
temp_file_path,
'-disable-availability-checking'
], desc='checking that rewritten file compiles')
sys.stdout.write(dump_rewritten_output) |
|
Hi jiaren wang (JIRA User), Thanks for taking a look at this. The Python code looks good so far. Once you’ve got the changes for |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: 458dfb2ad5767bae122573a9d4e0a092
Issue Description:
At the moment
refactor-check-compilesinvokesswift-refactortwice, once to generate the output for-dump-textand once to generate the output for-dump-rewritten. This is duplicated effort. We should instead add an option toswift-refactorthat outputs-dump-textto stdout and the contents of-dump-rewrittento a file. That way we could be generating both representations at the same time.If anyone wants to tackle this as a starter bug:
You would need to add a new flag like
-rewritten-output-filein swift-refactor.cpp that dumps the rewritten text to the specified output file, just like theDumpType::REWRITTENcase does today hereAfterwards, you’d need to update refactory-check-compiles.py to use that new argument to
swift-refactorto retrieve the rewritten code together with the invocation that has-dump-rewritten, getting rid of the path that calls-dump-textand writes its stdout to the temp file.The text was updated successfully, but these errors were encountered: