Comment by jiaren wang (JIRA)

arhaiziya (JIRA User) Here is what I am found: Fulfilled inverse expectations would be catch.

The note for Documentation for expectedfulfillmentcount has a precondition: Expectation is not fulfilled before wait was called.

if expectation.isFulfilled {
       // Check for any fulfilled inverse expectations. If they were fulfilled before wait was called,
       // this is where we'd catch that.
       if expectation.isInverted {
             return .fulfilledInvertedExpectation(invertedExpectation: expectation)
       } else {
             fulfilledExpectations.append(expectation)
       }
} else {
     unfulfilledExpectations.append(expectation)
}

@swift-ci create

Comment by Uladzislau Tarasevich (JIRA)

jiaren wang (JIRA User) Unfortunately, I'm barely getting what you mean.

Yes, fulfilled inverse expectations would be caught. But looking at the note in the docs and some code comments, it looks like that the expectedfulfillmentcount should be ignored (be equal to 1) for inverted expectations, isn't it?

/// The number of times `fulfill()` must be called on the expectation in order for it
/// to report complete fulfillment to its waiter. Default is 1.
/// This value must be greater than 0 and is not meaningful if combined with `isInverted`.
    open var expectedFulfillmentCount: Int {

So I believe that according to the docs setting expectedFulfillmentCount should be ignored for inverted expectations and the expectation should be fulfilled at the first call of fulfill(), regardless of any expectedFulfillmentCount value. That's what I am trying to say.

Possible problem place:

private func queue_fulfill(sourceLocation: SourceLocation) -> Bool {
    dispatchPrecondition(condition: .onQueue(XCTWaiter.subsystemQueue))

    numberOfFulfillments += 1

    if numberOfFulfillments == queue_expectedFulfillmentCount { // <<<<<
        queue_isFulfilled = true
        _fulfillmentSourceLocation = sourceLocation
        queue_fulfillmentToken = XCTestExpectation.queue_nextMonotonicallyIncreasingToken()
        return true
    } else {
        return false
    }
}

P.S.

1. If this is actually a bug, I would love to make a contribution to the repo myself, if it's possible of course 🙂
2. Sorry for the late response. I thought there would be some kind of notification by e-mail.

Comment by jiaren wang (JIRA)

arhaiziya (JIRA User) Thanks for your response.
According to your reply, It looks like the condition that you point out is missing isInverted checked.
Maybe the following is the solution?

    private func queue_fulfill(sourceLocation: SourceLocation) -> Bool {
        dispatchPrecondition(condition: .onQueue(XCTWaiter.subsystemQueue))

        numberOfFulfillments += 1

        if numberOfFulfillments == queue_expectedFulfillmentCount || queue_isInverted {
            queue_isFulfilled = true
            _fulfillmentSourceLocation = sourceLocation
            queue_fulfillmentToken = XCTestExpectation.queue_nextMonotonicallyIncreasingToken()
            return true
        } else {
            return false
        }
    }

Comment by Uladzislau Tarasevich (JIRA)

jiaren wang (JIRA User) Sure, at first glance, it can be a solution. But only if that note for expectedfulfillmentcount is relevant. Either it is a problem with documentation or code.