Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14611] The argument of hasSuffix that StringProtocol requires is currently wrongly named #56963

Closed
swift-ci opened this issue May 8, 2021 · 2 comments
Closed

[SR-14611] The argument of hasSuffix that StringProtocol requires is currently wrongly named #56963

swift-ci opened this issue May 8, 2021 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella

Comments

@swift-ci
Copy link
Collaborator

swift-ci commented May 8, 2021

Previous ID SR-14611
Radar None
Original Reporter ensan (JIRA User)
Type Bug
Status Closed
Resolution Done
Environment

Apple Swift version 5.4 (swiftlang-1205.0.26.9 clang-1205.0.19.55)
Target: x86_64-apple-darwin20.3.0

Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug
Assignee ensan (JIRA)
Priority Medium

md5: 6ee0dc96ce528d7b90a1423b9e29abc7

Issue Description:

The argument of hasSuffix that StringProtocol requires is currently wrongly named. It should be `suffix`.

https://github.com/apple/swift/blob/main/stdlib/public/core/StringProtocol.swift#L46
@swift-ci
Copy link
Collaborator Author

swift-ci commented May 8, 2021

Comment by ensan (JIRA)

Created PR that solves this.
#37336

@swift-ci
Copy link
Collaborator Author

swift-ci commented May 9, 2021

Comment by ensan (JIRA)

Fixed.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swift-ci