Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-14835] Availability checking is skipped for synthesized conformances #57182

Open
typesanitizer opened this issue Jun 27, 2021 · 1 comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@typesanitizer
Copy link

Previous ID SR-14835
Radar rdar://problem/79826333
Original Reporter @typesanitizer
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee None
Priority Medium

md5: a7fcf5d1d203edb2b92ff327dd7e8f7c

Issue Description:

Synthesized conformances do not print deprecation warnings.

struct S {
}
extension S: Equatable {
  @available(*, deprecated)
  static func ==(_: S, _: S) -> Bool { true }
  static func !=(_: S, _: S) -> Bool { false }
}
struct T: Equatable { // No warning even though S.== is deprecated
  let s: S
}
let _ = S() == S() // emits warning as expected

Is this intentional?

It also seems to ignore unavailable conformances altogether.

struct S { }
@available(*, unavailable) 
extension S: Equatable {
  static func ==(_: S, _: S) -> Bool { true }
  static func !=(_: S, _: S) -> Bool { false }
}
struct T: Equatable { // Compiles fine
  let s: S = S()
} 
print(T() == T()) // prints true

If the no-effect behavior above is intentional, then there should arguably be a warning at the declaration site of the @available that it won't have any effect and that it should be removed.

Tested with recent main.

@typesanitizer
Copy link
Author

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Development

No branches or pull requests

1 participant