Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-14948] Improve "couldn't find pc file" warning when pkgConfig property is used #4401

Open
neonichu opened this issue Jul 21, 2021 · 0 comments

Comments

@neonichu
Copy link
Member

Previous ID SR-14948
Radar rdar://67103084
Original Reporter @neonichu
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement
Assignee None
Priority Medium

md5: 57ede176f4262e352780fa921e4af6a9

Issue Description:

When a package manifest includes a package with a `pkgConfig` property, it’s evidently possible for local installations to be missing the specific `.pc` files. When that happens, we show a “couldn't find pc file” warning in the package resolution log, but that’s it — we should improve this warning and provide more context (e.g., which file couldn’t we find and why were we looking for it).

Example manifest, excerpted from the attached project:

```
let package = Package(
name: "swift-nio-zlib-support",
pkgConfig: "zlib")
```

In the case of zlib, installing the pkg-config CLI tool resolved the issue.

I think we should at least have a more descriptive name instead of "pc file" and should show the path(s) we looked at and for which file.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants