Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-15075] add @discardableResult to ThrowingTaskGroup.addTaskUnlessCancelled #57401

Open
swift-ci opened this issue Aug 16, 2021 · 3 comments
Open

[SR-15075] add @discardableResult to ThrowingTaskGroup.addTaskUnlessCancelled #57401

swift-ci opened this issue Aug 16, 2021 · 3 comments
Labels
improvement standard library Area: Standard library umbrella

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-15075
Radar rdar://problem/81984545
Original Reporter Fritzt (JIRA User)
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Improvement
Assignee None
Priority Medium

md5: 7af0bb2cc536014749e5755a46a9c545

Issue Description:

More often than not, I'm not interested in the boolean return value of addTaskUnlessCancelled, but need to prefix the call by _ = to silence the warning. It would be nice to have addTaskUnlessCancelled return that boolean as a discardable result.
@typesanitizer
Copy link

@swift-ci create

@swift-ci
Copy link
Collaborator Author

Comment by Minhyuk Kim (JIRA)

I'd be glad to have a take on this, but I'm curious if it's okay to just modify this function. Is there any process or discussion that should be done prior to making changes to an API like this? (even though it's ABI stable change I think?) theindigamer (JIRA User)

@typesanitizer
Copy link

I'm not sure if this requires a small evolution pitch or if this change can be made directly. cc kylemacomber (JIRA User)

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@typesanitizer @swift-ci