Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-15345] [Swift-DocC] Test fail on non-English locale machine #220

Closed
Kyle-Ye opened this issue Oct 16, 2021 · 3 comments
Closed

[SR-15345] [Swift-DocC] Test fail on non-English locale machine #220

Kyle-Ye opened this issue Oct 16, 2021 · 3 comments
Assignees
@Kyle-Ye
Labels
bug Something isn't working

Comments

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Oct 16, 2021

Previous ID SR-15345
Radar None
Original Reporter @Kyle-Ye
Type Bug
Status Resolved
Resolution Done

Attachment: Download

Additional Detail from JIRA
Votes 0
Component/s Swift-DocC
Labels Bug
Assignee @Kyle-Ye
Priority Medium

md5: 49de6cc6c7ad3340d0b88fa6b4180813

Issue Description:

Currently some test file in DocC like SemaToRenderNodeTests.swift have the following test expression.

```

XCTAssertEqual(firstTutorialReference.estimatedTime, "20 min")

```

The estimatedTime's implementation use DateComponentsFormatter. And will localize the time text according to the locale. While the test assume the English locale and use the raw string to compare.
@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 16, 2021

Pull Request: #7

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 16, 2021

Pull request in #7

@franklinsch
Copy link
Member

This was resolved in the above PR. Thanks for reporting and fixing this, @Kyle-Ye!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kyle-Ye Kyle-Ye

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ethan-kusters @franklinsch @Kyle-Ye