Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-15349] [Swift-DocC] Failing SemaToRenderNodeTests tests #219

Closed
swift-ci opened this issue Oct 18, 2021 · 2 comments
Closed

[SR-15349] [Swift-DocC] Failing SemaToRenderNodeTests tests #219

swift-ci opened this issue Oct 18, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@swift-ci
Copy link

Previous ID SR-15349
Radar None
Original Reporter maldahleh (JIRA User)
Type Bug
Status Closed
Resolution Duplicate
Environment

M1 Mac Mini

code as of commit: ff972f1

swift --version:

swift-driver version: 1.26.9 Apple Swift version 5.5 (swiftlang-1300.0.31.1 clang-1300.0.29.1)
Target: arm64-apple-macosx11.0
Additional Detail from JIRA
Votes 0
Component/s Swift-DocC
Labels Bug
Assignee @Kyle-Ye
Priority Medium

md5: 84033af5a23b1a72c09b3fcb000b4e64

Issue Description:

Running `./bin/test` produces:

/Users/maldahleh/Documents/swift/swift-docc/Tests/SwiftDocCTests/Model/SemaToRenderNodeTests.swift:896: error: -[SwiftDocCTests.SemaToRenderNodeTests testCompileOverviewWithVolumes] : XCTAssertEqual failed: ("Optional("20 min.")") is not equal to ("Optional("20min")")
/Users/maldahleh/Documents/swift/swift-docc/Tests/SwiftDocCTests/Model/SemaToRenderNodeTests.swift:902: error: -[SwiftDocCTests.SemaToRenderNodeTests testCompileOverviewWithVolumes] : XCTAssertEqual failed: ("Optional("1 hr. 20 min.")") is not equal to ("Optional("1hr 20min")")
Test Case '-[SwiftDocCTests.SemaToRenderNodeTests testCompileOverviewWithVolumes]' failed (0.220 seconds).

The tests are expecting the `estimatedTime` without periods, while the `estimatedTime` string includes periods.

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Oct 21, 2021

It seems you are not on a America-English-Locale, and the Formatter produce a different string than expected

Potential duplicates with https://bugs.swift.org/browse/SR-15345

See more discussion on #7

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Oct 27, 2021

Should be fixed by #7

Can you reproduce it on the new main branch, and if not would you please close the issue.🙂 maldahleh (JIRA User)

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants