Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-15353] Swift-DocC flaky test: CollectionConcurrentPerformTests.testSerialConcurrentPerform #217

Closed
franklinsch opened this issue Oct 18, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@franklinsch
Copy link
Member

Previous ID SR-15353
Radar rdar://84374211
Original Reporter @franklinsch
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Swift-DocC
Labels Bug
Assignee @QuietMisdreavus
Priority Medium

md5: ea9eb609ca1f6a58dc5503eecf6d43d7

Issue Description:

CollectionConcurrentPerformTests.testSerialConcurrentPerform is flaky on Swift CI Linux (Ubuntu 16.04). For example, the test passed in #1 but not in #2 and #11

@QuietMisdreavus
Copy link
Contributor

I've opened #13 to get more information as to what's going wrong, but running our CI is currently blocked by SR-15362. Once that's resolved (it has a PR open), i should be able to look into this more.

My current hunch is that there's either a resolution or precision issue with the systemUptime clock on one of the CI machines, that's causing an iteration to appear to have run either at or before the time that the previous one ended. Depending on the severity of it, it could be possible to change the assertion to allow for next.start >= result.end, or to add another delay after recording the end timestamp, which will still cause the test to fail if the queue were being run concurrently.

@QuietMisdreavus
Copy link
Contributor

The extra logging revealed that some loop iterations had the same "start" timestamp as the previous "end" timestamp. I updated the assertion to allow this, and ran CI 10 times without an issue. The PR has been merged.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants