Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-15479] [libSwiftPM] BuildOperation no longer emits diagnostics #4376

Open
krzyzanowskim opened this issue Nov 12, 2021 · 0 comments
Open

[SR-15479] [libSwiftPM] BuildOperation no longer emits diagnostics #4376

krzyzanowskim opened this issue Nov 12, 2021 · 0 comments
Labels
bug

Comments

@krzyzanowskim
Copy link
Contributor

Previous ID SR-15479
Radar None
Original Reporter @krzyzanowskim
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 8575736152cb2d79125c89f01b58d9af

Issue Description:

I testes on release/5.5 and on today's main branch (commit 86bd1fe) and it looks like `BuildOperation` no longer emit errors/warnings on failed builds. I believe it used to (am I wrong?)

After line calling BuildCommand.build() being called, and return with failure, nothing is emitted to the observabilityScope, not it reports any errors.

ref:

swift-package-manager/Sources/Build/BuildOperation.swift

Line 142 in 442f20e

let success = buildSystem.build(target: llbuildTarget)

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomerd @krzyzanowskim