Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-15570] SymbolKit: Parse symbol kinds with a known language #67

Open
QuietMisdreavus opened this issue Dec 7, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@QuietMisdreavus
Copy link
Contributor

Previous ID SR-15570
Radar None
Original Reporter @QuietMisdreavus
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Swift-DocC
Labels Improvement
Assignee None
Priority Medium

md5: a769a8f20a3a2a1a27d0ea7853785b56

Issue Description:

Currently, symbol kinds are parsed by comparing the kind string against a list of known symbol kinds, first as a whole and then with the first component discarded. However, this relies on the assumption that the first component of a symbol kind is a language identifier (e.g. `swift.func`). To prevent accidental loss of data, we should figure out a way to parse symbol kinds by taking their interface language into account.

The main problem here is the structure of the Decodable protocol: Each type's implementation is run in isolation, without taking into account the rest of the data being decoded. This will need to be handled somehow if we want to handle this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 3, 2022
@QuietMisdreavus
Copy link
Contributor Author

@shahmishal This should be transferred to swift-docc-symbolkit.

@d-ronnqvist d-ronnqvist transferred this issue from apple/swift-docc Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant