New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-15576] [Swift-DocC] Transform-for-static-hosting does not DocC's experimental custom header/footer feature #196
Comments
@swift-ci create |
We'll use this bug to track support specifically for `docc convert --transform-for-static-hosting --enable-experimental-custom-templates`. Support for `docc archive transform-for-static-hosting --enable-experimental-custom-templates` is tracked separately with SR-15750. |
I think this would be a good starter issue. Here's some thoughts on how to get started: DocC's transform for static hosting logic for
Separately, in Unfortunately, the
And so we end up in the situation where the I believe the simplest fix here would be to just move the call to An alternative solution would be to move the logic for injecting custom header/footer earlier in the process. Either way, we'll need to add a test that ensures that when a bundle that includes a custom header/footer is converted with support for static hosting, that custom header/footer is included in all of the copied |
@ethan-kusters can this be closed with the merge of #410? |
@mportiz08 Yes! Thank you for the ping. |
Additional Detail from JIRA
md5: c735028a1eb87105ac679771fac32b43
cloned to:
docc archive transform-for-static-hosting
should add support for experimental custom header/footer featurerelates to:
docc archive transform-for-static-hosting
should add support for experimental custom header/footer featureIssue Description:
Currently the `transform-for-static-hosting` action does not respect the experimental header/footer that can be provided in a DocC Catalog.
Since `transform-for-static-hosting` is still experimental, this lack of support did not block landing the initial implementation but it should be fixed for user's who want to host their docs in a static environment and take advantage of the experimental custom header/footer support.
The basics of what are needed to add support can be found here: ethan-kusters@119770f.
The text was updated successfully, but these errors were encountered: