Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-1561] Implement SE-0081 - Move where clause to end of declaration #44170

Closed
lattner mannequin opened this issue May 19, 2016 · 7 comments
Closed

[SR-1561] Implement SE-0081 - Move where clause to end of declaration #44170

lattner mannequin opened this issue May 19, 2016 · 7 comments
Assignees
@bitjammer
Labels
compiler The Swift compiler in itself generics Feature: generic declarations and types improvement parser Area → compiler: The legacy C++ parser swift evolution implemented Flag → feature: A feature that was approved through the Swift evolution process and implemented

Comments

@lattner
Copy link
Mannequin

lattner mannequin commented May 19, 2016

Previous ID SR-1561
Radar rdar://problem/17203060
Original Reporter @lattner
Type New Feature
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels New Feature, Parser
Assignee @bitjammer
Priority Medium

md5: 4a194cc0762cff7ff652c2569bcae415

Issue Description:

SE-0081 has been accepted, we need an implementation:
https://github.com/apple/swift-evolution/blob/master/proposals/0081-move-where-expression.md
@swift-ci
Copy link
Collaborator

Comment by Hugo Hennies (JIRA)

I'd really love to try this out, but I'd need some initial pointers to get started. On which classes to look, some pitfalls I might want to watch out for. Maybe a similar issue/PR/commit I could take a look at.

Thanks in advance.

@lattner
Copy link
Mannequin Author

lattner mannequin commented May 30, 2016

I implemented parser support for the new form in c5bf433. The next step is to migrate the test suite, corelibs, and stdlib to the new form. I'd really appreciate help with that.

@rintaro
Copy link
Mannequin

rintaro mannequin commented May 31, 2016

If no one have started stdlib migration yet, I'd love to work on it.

@bitjammer
Copy link
Member

It looks like the standard library is migrated.

@rintaro
Copy link
Mannequin

rintaro mannequin commented Jul 20, 2016

@bitjammer Sorry, I forgot to mention that here.

I also have WIP branch for test suite migration.
master...rintaro:se-0081-migrate-testsuite
It's very old. I rebased it on current master.
I hope someone take over this.

@Dante-Broggi
Copy link
Contributor

Wasn't this implemented in Swift 3?

@belkadan
Copy link
Contributor

Yep, right around when Ashley transferred to another team. Ah well.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added improvement generics Feature: generic declarations and types swift evolution implemented Flag → feature: A feature that was approved through the Swift evolution process and implemented and removed new feature labels Nov 12, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitjammer bitjammer

Labels
compiler The Swift compiler in itself generics Feature: generic declarations and types improvement parser Area → compiler: The legacy C++ parser swift evolution implemented Flag → feature: A feature that was approved through the Swift evolution process and implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bitjammer @belkadan @swift-ci @AnthonyLatsis @Dante-Broggi