Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-15692] Output currently printed to stdout stream should go through the same system as diagnostics (with a new output severity) #4364

Open
abertelrud opened this issue Jan 6, 2022 · 1 comment
Assignees
Labels

Comments

@abertelrud
Copy link
Contributor

Previous ID SR-15692
Radar rdar://problem/87204017
Original Reporter @abertelrud
Type Task
Additional Detail from JIRA
Votes 1
Component/s Package Manager
Labels Task
Assignee @abertelrud
Priority Medium

md5: 2305febebc5504cf57950d738c736911

Issue Description:

Today the build system and other subsystems send some output directly to a stdout stream (such as output printed by plugins), while diagnostics go through the observability system.

It would be better to send everything through the same funnel, which would allow:

  • proper ordering between emitted diagnostics and plain-text output

  • a way to add metadata to the output (such as identifying which plugin emitted the output)

A good approach would probably be to split each line of output into a separately emittable diagnostic.

The presentation of that output is then a separate concern, but its logic would be simpler if everything went through the same API and had metadata associated with it.

A suggestion would be to have a new `output` severity between `info` and `warning` which would be shown by default (to preserve current behavior of emitting stdout stream text).

@abertelrud
Copy link
Contributor Author

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants