Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-15753] Properly export top-level decls from @_exported import modules into the symbol graph #190

Closed
QuietMisdreavus opened this issue Jan 19, 2022 · 3 comments
Assignees
Labels
enhancement Improvements or enhancements to existing functionality

Comments

@QuietMisdreavus
Copy link
Contributor

Previous ID SR-15753
Radar rdar://89547374
Original Reporter @QuietMisdreavus
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Swift-DocC
Labels Improvement
Assignee @franklinsch
Priority Medium

md5: 3036c7fd1b6ab90027e1cf5a38812878

Issue Description:

While investigating apple/swift#40860, i noticed that symbols from @_exported import are not getting included in the symbol graph file of the module that imports them. Since these symbols are part of the module's API, its symbol graph file should contain them.

@franklinsch
Copy link
Member

@QuietMisdreavus I think the description of this bug got cut off? 🙂

@franklinsch
Copy link
Member

@swift-ci create

@franklinsch
Copy link
Member

PR: apple/swift#41577

My patch here doesn't work when extracting symbol graph files with swift-symbolgraph-extract. I filed https://bugs.swift.org/browse/SR-15921 to track this.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or enhancements to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants