Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-1677] Link with libdispatch when building SourceKit on Linux #44286

Closed
briancroom opened this issue Jun 3, 2016 · 4 comments
Closed

[SR-1677] Link with libdispatch when building SourceKit on Linux #44286

briancroom opened this issue Jun 3, 2016 · 4 comments
Assignees
@jpsim
Labels
task

Comments

@briancroom
Copy link
Collaborator

Previous ID SR-1677
Radar None
Original Reporter @briancroom
Type Task
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels Task, linux
Assignee @jpsim
Priority Medium

md5: aa8068473e9c96b534e0085a76aba842

blocks:

Issue Description:

Some pains have been taken within SourceKit to make `libdispatch` an optional dependency (e.g. the `WorkQueue` abstraction in `SourceKitSupport`, however it is neither used everywhere, nor are any implementations available besides the one that uses `libdispatch`. Since `libdispatch` is intended to be available anywhere Swift is anyway, it seems reasonable to go ahead and use it here, at least for now.

(Note that an alternative to this could be to remove `libdispatch` usage instead. See #2793
@briancroom
Copy link
Collaborator Author

PR: #2862

@jpsim
Copy link
Contributor

jpsim commented Jul 19, 2016

Brian shared with me that he won't be able to devote the time to continue this work moving forward, so I've assigned myself to this ticket and updated the PR with this one: #3594

@modocache
Copy link
Mannequin

modocache mannequin commented Jul 29, 2016

@jpsim, is this issue resolved? Feel free to close it if so. If you could also update https://bugs.swift.org/browse/SR-1677, that'd be great. 🙂

@jpsim
Copy link
Contributor

jpsim commented Jul 29, 2016

SourceKit now always links with libdispatch on Linux.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpsim jpsim

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsim @briancroom