Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-180] Packages have assertions enabled in the standard library #42802

Closed
gribozavr opened this issue Dec 10, 2015 · 2 comments
Closed

[SR-180] Packages have assertions enabled in the standard library #42802

gribozavr opened this issue Dec 10, 2015 · 2 comments
Assignees
@gribozavr
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script compiler The Swift compiler in itself

Comments

@gribozavr
Copy link
Collaborator

Previous ID SR-180
Radar None
Original Reporter @gribozavr
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, BuildScript
Assignee @gribozavr
Priority Medium

md5: a4b00a01b65b6172b3fdfb727225816e

Issue Description:

It looks like our packages have assertions enabled in the standard library. It is caused by a bad workaround here:

[preset: mixin_lightweight_assertions]
assertions

# FIXME: This should be:
# no-assertions
# swift-assertions
# ... but our tests are expecting assertions to be either on or off everywhere.
@gribozavr
Copy link
Collaborator Author

Patch:

diff --git a/utils/build-presets.ini b/utils/build-presets.ini
index 6dc6d24..11494bd 100644
--- a/utils/build-presets.ini
+++ b/utils/build-presets.ini
@@ -463,6 +463,7 @@ swift-runtime-enable-leak-checker=1
 # compiler significantly.
 [preset: mixin_lightweight_assertions]
 assertions
+no-swift-stdlib-assertions

 # FIXME: This should be:
 # no-assertions

Built a package on OS X, testing on Linux.

@gribozavr
Copy link
Collaborator Author

Blocking issues have been resolved or tests have been XFAIL'ed.

commit 630f4650c49416ae90c299618e06eadb3c6cb6c3
Author: Dmitri Gribenko <gribozavr@gmail.com>
Date:   Fri Dec 11 16:01:46 2015 -0700

    build-presets: disable standard library assertions in packages

    https://bugs.swift.org/browse/SR-180

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gribozavr gribozavr

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script compiler The Swift compiler in itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gribozavr