New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-1861] Swift build crashes C Modulemap packages #5361
Comments
Comment by Dan Appel (JIRA) We discussed this a little bit in the SPM slack and found that building these packages standalone is not really supported yet. Hence, the solution here would be to add the functionality to build C modulemap packages. In my opinion, the expected behavior in this case would be to test the modulemap's validity by making a dummy swift module and attempting to import the c module in it, which would then throw errors regarding headers and linking if they were to arise. |
I agree with Dan it would be awesome to test the module map validity in this case... In the shorter term we should at least not fail with a confusing error message |
Added a PR for improving the error message: #462 |
The PR for better error message has been merged. |
Fixed by #462 |
Environment
Tested with the 05-09 and 06-06 snapshots, along with the Xcode 8.0 Swift preview. Can reproduce on all of them. Also fails on Linux (tested in a Ubuntu 14.04 docker container).
Additional Detail from JIRA
md5: c01e64dbf76dcd9e984ed6534fa107bb
duplicates:
Issue Description:
Steps to reproduce:
Output:
Breaks with other similar-style c packages as well ([Clibbson](https://github.com/danappelxx/clibbson), [CMysql](https://github.com/zewo/cmysql)); but doesn't break with packages that have C sources ([CLibvenice](https://github.com/venicex/clibvenice), [CHTTPParser](https://github.com/zewo/chttpparser)).
The text was updated successfully, but these errors were encountered: