Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-1955] Consider renaming or eliminating ManagedProtoBuffer. #44564

Closed
gribozavr opened this issue Jul 1, 2016 · 1 comment
Closed

[SR-1955] Consider renaming or eliminating ManagedProtoBuffer. #44564

gribozavr opened this issue Jul 1, 2016 · 1 comment
Assignees
@eeckstein
Labels
affects ABI Flag: Affects ABI feature A feature request or implementation standard library Area: Standard library umbrella swift evolution implemented Flag → feature: A feature that was approved through the Swift evolution process and implemented

Comments

@gribozavr
Copy link
Collaborator

gribozavr commented Jul 1, 2016 •
edited by AnthonyLatsis

Previous ID SR-1955
Radar rdar://problem/26012924
Original Reporter @gribozavr
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug, AffectsABI, swift-evolution-proposal-needed
Assignee @eeckstein
Priority Medium

md5: 697c8ab05240578c1d24b279fd3d6bc6

Issue Description:

The reason why ManagedProtoBuffer exists is to give the users an extra bit of type safety inside of the closure passed to ManagedBuffer.create(). This closure receives the ManagedBuffer instance and returns the initial value that is stored in the buffer (the header part of the buffer). We are passing the ManagedBuffer as ManagedProtoBuffer to prevent the closure from reading the uninitialized value property. Maybe this extra bit of safety is not worth the API surface complexity.

NOTE: Requires a swift-evolution proposal. apple/swift-evolution#437
@bob-wilson
Copy link

This is done now as part of SE-0127.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added feature A feature request or implementation swift evolution implemented Flag → feature: A feature that was approved through the Swift evolution process and implemented and removed bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. swift evolution proposal needed Flag → feature: A feature that warrants a Swift evolution proposal labels Mar 22, 2023
@AnthonyLatsis AnthonyLatsis mentioned this issue Mar 22, 2023
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eeckstein eeckstein

Labels
affects ABI Flag: Affects ABI feature A feature request or implementation standard library Area: Standard library umbrella swift evolution implemented Flag → feature: A feature that was approved through the Swift evolution process and implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gribozavr @bob-wilson @AnthonyLatsis