Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-2082] [SwiftPM] Switch clean to be a swift build mode. #5247

Closed
ddunbar opened this issue Jul 15, 2016 · 5 comments
Closed

[SR-2082] [SwiftPM] Switch clean to be a swift build mode. #5247

ddunbar opened this issue Jul 15, 2016 · 5 comments
Labels
bug

Comments

@ddunbar
Copy link
Member

ddunbar commented Jul 15, 2016

Previous ID SR-2082
Radar None
Original Reporter @ddunbar
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: 33c72eea8297b2bd7819aae0bf0bdc29

Issue Description:

We should make `swift build --clean` become `swift build clean` to be more consistent with modes versus options.
@swift-ci
Copy link
Contributor

Comment by Sam Symons (JIRA)

Is it acceptable to consider `clean` an option internally? i.e., resolving this ticket by simply swapping the string checks in `SwiftBuildTool.swift` and related tests from `--clean` to `clean`.

@ddunbar
Copy link
Member Author

ddunbar commented Jul 18, 2016

It would be nice to make the code clean for handling this situation, if it is the pattern we are going to use going forward it should be easy to extend.

The other important part of this is probably vetting it with the community.

@swift-ci
Copy link
Contributor

Comment by Sam Symons (JIRA)

Agreed, it would be great to have modes treated as more than simply an option with a different naming convention. I'm going to dig into this a little bit more, but I'll leave the issue unassigned in case I don't get time to submit a PR.

@abertelrud
Copy link
Contributor

This doesn't seem to be in scope for Swift 3 anymore at this point.

@ankitspd
Copy link
Member

ankitspd commented Nov 1, 2016

#775

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ddunbar @ankitspd @swift-ci @abertelrud