Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-210] Teach SIL Parser how to parse switch_enum of undef #42832

Closed
gottesmm opened this issue Dec 13, 2015 · 3 comments
Closed

[SR-210] Teach SIL Parser how to parse switch_enum of undef #42832

gottesmm opened this issue Dec 13, 2015 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers

Comments

@gottesmm
Copy link
Member

Previous ID SR-210
Radar None
Original Reporter @gottesmm
Type Bug
Status Resolved
Resolution Done

Attachment: Download

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee emanuel (JIRA)
Priority Medium

md5: d8465825ed89ef9f3ca543e7c3372d2e

Issue Description:

Currently swift_enum does not properly handle undef correctly. I have a preliminary patch that I wrote, but I have not had time to commit it/write tests.

There is a bunch of work in the SILParser that still needs to be done and this may be a good task for someone who is interested in poking around the SILParser and needs a starting point.

Attached is the patch.
@gottesmm
Copy link
Member Author

If you have any questions, feel free to shoot me an email/etc.

@swift-ci
Copy link
Collaborator

Comment by Emanuel Zephir (JIRA)

Pull request submitted at #634

@swift-ci
Copy link
Collaborator

Comment by Emanuel Zephir (JIRA)

Merged as commit 4c5eee9

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gottesmm @swift-ci