[SR-2239] CVaListPointer does not gets converted to va_list on aarch64
#44846
Comments
|
I think it worths to be said that the exact same codebase checked out at the same time in a x86_64 linux 16.04 emulator worked fine. This seems to be an |
|
Comment by Neon (JIRA) I just learned that arm aarch64 != apple arm64. The arm aarch64 ABI defines __va_list as: struct __va_list
{
void *__stack;
void *__gr_top;
void *__vr_top;
int __gr_offs;
int __vr_offs;
};but for apple arm64 it is char*. Is it possible that swift is only working with apple arm64 but clang has arm aarch64 implemented? |
|
Is this issue related to https://bugs.swift.org/browse/SR-3429 ? |
|
@modocache, unlikely that they are related. This would need to work before that can even occur as this issue prevents the definition of `CVaListPointer` entirely. |
|
Partial WIP patch at apple/swift#12623. The ClangImporter still needs adjustment and _VaListBuilder needs to be completed. |
|
The only bit that remains is fixing the _VaListBuilder which seems to not be getting interpreted properly. |
|
We now have a fix for this issue. This fix has been tested on a variety of arm64/aarch64 devices, from small SBC's like the RaspberryPi and Rock64, to high end Cavium ThunderX servers. We need this issue resolved urgently as it is blocking successful builds on the new AArch64 CI - https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-aarch64/ |
|
Comment by Ed Vielmetti (JIRA) @compnerd please take a look? We have a new CI system ready to go, blocked at the moment on this bug. |
Environment
OS: Ubuntu 16.04 xenial
Kernel: 3.10.65-7-pine64-longsleep #28 SMP PREEMPT Sat Apr 23 20:13:25 CEST 2016 aarch64 aarch64 aarch64 GNU/Linux
CPU: Cortex A53 / ARMv8-A (active state AArch64) @ 1.2Ghz x 4 cores
Board: Pine64
Additional Detail from JIRA
md5: 9e146d43940f2f8d25705b8c9685e5fc
is duplicated by:
Issue Description:
I'm getting an error when trying to compile
corelibs-foundationinarm. When the compile process is done with CoreFoundation and gets to the Swift wrappers, it's failing trying to compileNSString.init(format: String: arguments: CVaListPointer)and sibling methods.cannot convert value of type 'CVaListPointer' to expected argument type 'va_list' (aka '__va_list')SR-1412 reported problems when trying to resolve the correct
va_listinarm. Based on the error message we're getting, and what was the issue at that time, my theory isswiftproject is resolvingva_listand__va_listin a different way ascorelibs-foundationdoes forarm's toolchain. Then the mapped types defined here are failing to work:swift/lib/ClangImporter/MappedTypes.def
Lines 126 to 130 in 621d3b7
Again, is just a theory, I couldn't prove it yet.
Complete compilation call as executed by the build script with the following parameters:
utils/build-script -R --libdispatch 1 --xctest 1 --foundation 1The text was updated successfully, but these errors were encountered: