Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-2406] Print __attribute__((noescape)) in the generated header #45013

Closed
belkadan opened this issue Aug 19, 2016 · 2 comments
Closed

[SR-2406] Print __attribute__((noescape)) in the generated header #45013

belkadan opened this issue Aug 19, 2016 · 2 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers PrintAsClang Area → compiler: The PrintAsClang library

Comments

@belkadan
Copy link
Contributor

Previous ID SR-2406
Radar rdar://problem/22885266
Original Reporter @belkadan
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, PrintAsObjC, StarterBug
Assignee @belkadan
Priority Medium

md5: 2514d7b6317734b9c741b4d583e99dfd

relates to:

  • SR-2529 Keep attribute((noescape)) when importing Clang types
  • SR-2520 Type alias is lost when applying @escaping-ness

Issue Description:

If a Swift method takes a non-escaping closure parameter, the generated header should include __attribute__((noescape)) on that parameter's type.

@jtbandes
Copy link
Collaborator

Am I correct in thinking that the attribute should only be printed when the type in question is the type of a function param? If so, do you think it makes sense to add another argument to print() indicating whether we are printing a function param?

@jtbandes
Copy link
Collaborator

Implementing in #4438

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers PrintAsClang Area → compiler: The PrintAsClang library
Projects
None yet
Development

No branches or pull requests

2 participants