Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-2409] Diagnostic refers to "Objective-C module" even on Linux #45016

Closed
belkadan opened this issue Aug 19, 2016 · 3 comments
Closed

[SR-2409] Diagnostic refers to "Objective-C module" even on Linux #45016

belkadan opened this issue Aug 19, 2016 · 3 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers

Comments

@belkadan
Copy link
Contributor

Previous ID SR-2409
Radar rdar://problem/23361191
Original Reporter @belkadan
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, ClangImporter, DiagnosticsQoI, StarterBug
Assignee @d-ronnqvist
Priority Medium

md5: a38aa3237a6739f84edb3933ba8f8eb6

Issue Description:

We have a diagnostic for when we fail to import a module from Clang (say, because there's an error in the headers). Unfortunately, that diagnostic says "could not build Objective-C module 'Foo'", even though on Linux there's no Objective-C. We should rephrase that diagnostic and/or make it platform-dependent.

@swift-ci
Copy link
Collaborator

swift-ci commented Sep 1, 2016

Comment by Husein Kareem (JIRA)

Opened a PR ---> #4587

@modocache
Copy link
Mannequin

modocache mannequin commented Dec 29, 2016

Thanks for the pull request, hkareem2222 (JIRA User)! It seems like it was very close to what the original reporter had in mind. Are you planning to continue working on this? If so, feel free to assign this task to yourself.

@d-ronnqvist
Copy link
Contributor

I've opened a PR to complete this work.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants