Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-247] SILParser needs to parse conformances when parsing init_existential_ref init_existential_metatype_inst #42869

Closed
gottesmm opened this issue Dec 16, 2015 · 1 comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers

Comments

@gottesmm
Copy link
Member

Previous ID SR-247
Radar None
Original Reporter @gottesmm
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee emanuel (JIRA)
Priority Medium

md5: 9e2ce64f706bfd1e60b6deb2974bba58

Issue Description:

Currently we have these two fixes in the SILParser.


// FIXME: Conformances in InitExistentialRefInst is currently not included
// in SIL.rst.
ResultVal = B.createInitExistentialRef(InstLoc, ExistentialTy,
FormalConcreteTy, Val,
conformances);
break;
}
case ValueKind::InitExistentialMetatypeInst: {
SILType ExistentialTy;
if (parseTypedValueRef(Val, B) ||
P.parseToken(tok::comma, diag::expected_tok_in_sil_instr, ",") ||
parseSILType(ExistentialTy))
return true;

// FIXME: We should be parsing conformances here.
ResultVal = B.createInitExistentialMetatype(InstLoc


We need to parse the conformances here and right some test cases. I have run into the first before, but not the second. I think I have a patch that implements one or the other. I will attach it if I can find it.

@swift-ci
Copy link
Collaborator

Comment by Emanuel Zephir (JIRA)

I've started pull request 786 with a partial fix and a few questions about how to advance towards a commit worthy solution.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants