[SR-2483] caret new line String "\r\n" crashes in String.components #4332
Assignees
Labels
Comments
|
The backtrace is: 4 libFoundation.so 0x00007f140474d8f2 _TTSf4s_n___TFC10Foundation8NSString9substringfT4withVS_8_NSRange_SS + 562
5 libFoundation.so 0x00007f1404741b2a _TFC10Foundation8NSString10componentsfT11separatedByVS_12CharacterSet_GSaSS_ + 474
6 libFoundation.so 0x00007f1404753381 _TFE10FoundationSS10componentsfT11separatedByVS_12CharacterSet_GSaSS_ + 49
7 libFoundation.so 0x00007f140fde1098 _TFE10FoundationSS10componentsfT11separatedByVS_12CharacterSet_GSaSS_ + 191421768On closer examination I found that the String.init(utf16View) call here, returns nil: The reason for String(utf16View) returning nil can be seen the following code that prints nil on both Darwin and Linux: let str = "\r\n"
let start = str.utf16.startIndex
let min = start.advanced(by: 1)
let max = start.advanced(by: 1)
print(String(str.utf16[min..<max]))I'd propose that on line 349 in NSString.swift, we check for nil and return an empty string for a nil. |
|
In short for "\r\n", the utf16View[0..<0] is "" but utf16View[1..<1] is nil This behaviour is consistent with Darwin |
|
"\r\n" is (are?) counted as 1 character. print("\r\n".characters.count) //this prints 1That explains why "\r\n". utf16View[1..<1] returns nil |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: d145092765f170e4683f665e97822e31
relates to:
Issue Description:
The following line produces core dump on Linux:
let _ = "\r\n".components(separatedBy: CharacterSet.whitespacesAndNewlines)
The text was updated successfully, but these errors were encountered: