Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-2613] [SwiftPM] Second build of Vapor project isn't properly null #5219

Closed
ddunbar opened this issue Sep 12, 2016 · 5 comments
Closed

[SR-2613] [SwiftPM] Second build of Vapor project isn't properly null #5219

ddunbar opened this issue Sep 12, 2016 · 5 comments
Assignees
@ddunbar
Labels
bug

Comments

@ddunbar
Copy link
Member

ddunbar commented Sep 12, 2016

Previous ID SR-2613
Radar rdar://problem/28253551
Original Reporter @ddunbar
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s llbuild, Package Manager
Labels Bug
Assignee @ddunbar
Priority Medium

md5: 0e985409798965e6c570c96fa605492e

is duplicated by:

  • SR-2748 package manager rebuilding unchanged modules

Issue Description:

Running two builds in a row on a trivial Vapor project:

    dependencies: [
        .Package(url: "https://github.com/vapor/vapor.git", majorVersion: 0),
    ]

does not result in a null build. It should.
@ddunbar
Copy link
Member Author

ddunbar commented Sep 12, 2016

This doesn't reproduce if I just run the swift-build-tool invocation. This either has to do with the files we generate during building, or we aren't generating a deterministic manifest file maybe?

@ddunbar
Copy link
Member Author

ddunbar commented Sep 12, 2016

It looks like this is because we are rewriting .build/debug/CLibreSSL.build/module.modulemap every time we build.

@aciidb0mb3r, can we switch the module map generation to only rewrite when changed, and get a small test case for this?

@ankitspd
Copy link
Member

Ah yes, will do

@ankitspd
Copy link
Member

#646

@ddunbar
Copy link
Member Author

ddunbar commented Sep 14, 2016

Merged

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddunbar ddunbar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddunbar @ankitspd