Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-265] Sort resilient enum cases, protocol requirements, virtual methods, etc by availability #42887

Closed
slavapestov opened this issue Dec 17, 2015 · 5 comments
Closed

[SR-265] Sort resilient enum cases, protocol requirements, virtual methods, etc by availability #42887

slavapestov opened this issue Dec 17, 2015 · 5 comments
Assignees
@slavapestov
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@slavapestov
Copy link
Member

Previous ID SR-265
Radar rdar://24057946
Original Reporter @slavapestov
Type Bug
Status Resolved
Resolution Won't Do
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee @slavapestov
Priority Medium

md5: d4b82a1bd7c9ee09090979e2ac8292f0

blocks:

  • SR-257 Resilient value type support -- umbrella bug

Issue Description:

We want to add new cases in any order as long as they have higher availability than the rest.
@belkadan
Copy link
Contributor

Don't we need to sort everything by availability?

@slavapestov
Copy link
Member Author

Probably, I haven't thought that far ahead. :-)

@slavapestov
Copy link
Member Author

rdar://24057946

@bob-wilson
Copy link

The change made for that radar was #15208

Slava, can you explain the "Won't Do" resolution that you entered here? Is that one change all that is needed?

@slavapestov
Copy link
Member Author

Ah, I see. Sorry for the confusion. The radar was repurposed to mean "enum cases should be re-orderable", and that was implemented by hiding enum case indices in global variables, rather than any kind of sorting by availability.

We didn't do availability sorting because in all other cases – protocol requirements, class methods and enum case indices – we found alternate solutions.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavapestov slavapestov

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slavapestov @belkadan @bob-wilson