Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-2653] Allow CMake SWIFT_BUILD_SOURCEKIT to be enabled/disabled via build-script #45258

Open
modocache mannequin opened this issue Sep 15, 2016 · 2 comments
Open

[SR-2653] Allow CMake SWIFT_BUILD_SOURCEKIT to be enabled/disabled via build-script #45258

modocache mannequin opened this issue Sep 15, 2016 · 2 comments
Labels
good first issue Good for newcomers improvement

Comments

@modocache
Copy link
Mannequin

modocache mannequin commented Sep 15, 2016

Previous ID SR-2653
Radar None
Original Reporter @modocache
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Improvement, StarterBug
Assignee None
Priority Medium

md5: 9e97a17cc680616ce092d753d43de0a3

Issue Description:

I'm currently attempting to cross-compile the stdlib for Android using a macOS host. One snag is that apple/swift/CMakeLists.txt adds a SourceKit target if the host machine is Darwin, and does not add it if the host is Linux. I should be able to turn SourceKit builds on or off via the build-script.

Following the project's convention, this should probably be an option named --skip-build-sourcekit. On Linux, utils/build-script should pass this option by default. On Darwin, it should not.
@modocache
Copy link
Mannequin Author

modocache mannequin commented Sep 15, 2016

Scratching my own itch here: #4806

@modocache
Copy link
Mannequin Author

modocache mannequin commented Sep 22, 2016

Apparently my approach isn't ideal here. Others should feel free to try to do it right, I might not be able to update my pull request for another few days.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants