Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-267] Don't build standard library with -sil-serialize-all #42889

Closed
slavapestov opened this issue Dec 17, 2015 · 7 comments
Closed

[SR-267] Don't build standard library with -sil-serialize-all #42889

slavapestov opened this issue Dec 17, 2015 · 7 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. cmake standard library Area: Standard library umbrella

Comments

@slavapestov
Copy link
Member

Previous ID SR-267
Radar rdar://problem/24057969
Original Reporter @slavapestov
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug, CMake
Assignee @slavapestov
Priority Medium

md5: 1d83d7d906511e1cc2b56f4386df8bd4

blocks:

  • SR-257 Resilient value type support -- umbrella bug
  • SR-268 Add build flag for building standard library with resilience enabled

Issue Description:

This is required for building the standard library with -enable-resilience, which we want to do to test this feature.

@belkadan
Copy link
Contributor

We can probably turn this off at any time; we just have drastic performance issues when we do. The real work is in deciding which parts of the stdlib should be resilient and which should not, and then verifying that we don't leak any of the resilient details into the public SIL.

@eeckstein
Copy link
Member

I agree. We should not turn this off until the performance is OK. Is there a ticket to track this work?

@belkadan
Copy link
Contributor

Well, we need to be able to start testing things before we can actually measure the performance, so we will still need a flag for this. But maybe that's covered by SR-268.

@eeckstein
Copy link
Member

Removing -sil-serialize-all itself is a trivial change. Just remove it the relevant option in cmake/modules/AddSwift.cmake.
So testing can be done easily.
All I'm saying is that we should not remove the option per default in ToT until the performance issues are resolved.

@slavapestov
Copy link
Member Author

rdar://24057969

@eeckstein
Copy link
Member

I just talked to Slava. He will take this.

@slavapestov
Copy link
Member Author

This is mostly done, only a few tests fail, so I'm going to close this.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. cmake standard library Area: Standard library umbrella
Projects
None yet
Development

No branches or pull requests

3 participants