Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-2858] Ninja rule declarations should support file scoping #796

Closed
ddunbar opened this issue Oct 5, 2016 · 3 comments
Closed

[SR-2858] Ninja rule declarations should support file scoping #796

ddunbar opened this issue Oct 5, 2016 · 3 comments
Assignees
@ddunbar
Labels
Improvement llbuild StarterBug

Comments

@ddunbar
Copy link
Member

ddunbar commented Oct 5, 2016

Previous ID SR-2858
Radar rdar://problem/28616636
Original Reporter @ddunbar
Type Improvement
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s llbuild
Labels Improvement, StarterBug
Assignee @ddunbar
Priority Medium

md5: 43f275d3fb8947caad8f8bce237db398

Issue Description:

In Ninja 1.6, rule declarations began to support per-file scoping, see https://ninja-build.org/manual.html#ref_scope

llbuild's Ninja implementation should support this (and match whatever related behavioral changes happened).
@ddunbar
Copy link
Member Author

ddunbar commented Oct 5, 2016

Tagging as a starter bug: this is most likely a matter of moving the rule lookup tables down into our scope objects, and doing the lookup there (we already do similar things to honor the evaluation scopes).

@ddunbar
Copy link
Member Author

ddunbar commented Jul 13, 2019

Fixed here:

#507

@ddunbar
Copy link
Member Author

ddunbar commented Jul 13, 2019

ed4b3b6

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddunbar ddunbar

Labels
Improvement llbuild StarterBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddunbar