Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-2910] Log property name for synthesized properties in -debug-time-function-bodies output #45504

Closed
swift-ci opened this issue Oct 10, 2016 · 5 comments
Assignees
Labels
compiler The Swift compiler in itself improvement

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-2910
Radar None
Original Reporter benasher44 (JIRA User)
Type Improvement
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement
Assignee @modocache
Priority Medium

md5: 22cd8d7a71c4b1e50fd45e5e5d56dcff

Issue Description:

Generated getters and setters don't have their names printed alongside them in the log output for -debug-time-function-bodies. Here are some examples:

get {}
set {}
final get {}
final set {}
@objc get {}
@objc set {}
@objc final get {}
@objc final set {}
(closure)

The log output already includes the source location of the property, but it'd be an improvement if instead these looked more like:

set foo {}
get foo {}
…
etc.

instead of seeing a wall of getters and setters that all look the same 🙂

@swift-ci
Copy link
Collaborator Author

Comment by Ben A (JIRA)

This could be helpful when chasing down bugs like SR-2901

@swift-ci
Copy link
Collaborator Author

Comment by Ben A (JIRA)

I think logging the name of the type of the property would also be welcome here.

@modocache
Copy link
Mannequin

modocache mannequin commented Nov 15, 2017

I sent up #12939 as a first pass at addressing this. Thanks for the descriptive bug report! 🙂

@swift-ci
Copy link
Collaborator Author

Comment by Ben A (JIRA)

Awesome!!

@modocache
Copy link
Mannequin

modocache mannequin commented Nov 16, 2017

I merged #12939 and I think that resolves this issue. Please close once you've confirmed it's fixed in your eyes, benasher44 (JIRA User). Thanks for the report!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself improvement
Projects
None yet
Development

No branches or pull requests

1 participant